Skip to content

[Rust][Client] Correct the Rust client generated documentation #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

bcourtine
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

/cc @frol @farcaller @bjgill

Description of the PR

Fixes #3418. Only generated API markdown files are impacted.

Copy link
Contributor

@bjgill bjgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

This has been irritating me for a while - thanks!

Change is simple, so I'm happy to merge this without waiting for further reviews.

@bjgill bjgill added this to the 4.1.0 milestone Jul 24, 2019
@bjgill bjgill merged commit 28a16be into OpenAPITools:master Jul 24, 2019
@wing328
Copy link
Member

wing328 commented Aug 10, 2019

@bcourtine thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Rust client] Generated API documentation contains obvious errors
3 participants