Guarantee a unique name for the constants that represent enum values #3644
Conversation
| PLACED OuterEnum = "placed" | ||
| APPROVED OuterEnum = "approved" | ||
| DELIVERED OuterEnum = "delivered" | ||
| OuterEnum_PLACED OuterEnum = "placed" |
There was a problem hiding this comment.
Would it be better if it's all upper case, e.g. OUTERENUM_PLACED?
Ref: https://stackoverflow.com/a/22688926/677735
We also need an option so that users can stick with the current behavior instead (e.g. PLACED instead of OUTERENUM_PLACED)
There was a problem hiding this comment.
Well, the Go guides are pretty adamant about using mixed case, but I elected not to change the part that was already there that didn't. But I can uppercase the typename for consistency.
Unfortunately I doubt I'll dig into the code enough to learn how to add an option flag.
|
I'll add the option in another PR. |
|
Filed #3675 |
|
#3675 has been merged into master. To enable it, please do |
|
@kraney thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737 |
Proposed fix for #3518
This change adds a prefix to the consts that are defined to represent enum values. This prevents name collisions between different enums having the same value within.