Skip to content

[Python] Use Python 2.6 compatible dict definition #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Python] Use Python 2.6 compatible dict definition #4443

wants to merge 2 commits into from

Conversation

richardwhiuk
Copy link
Contributor

@richardwhiuk richardwhiuk commented Nov 10, 2019

This changes the generated client to use a Python 2.6 compatible dictionary definition, which allows the client (on at least some APIs) to work on Python 2.6

This work was contributed by @nick-slack at @Metaswitch.

Python Technical Committee

@taxpon, @frol, @mbohlool, @cbornet, @kenjones-cisco, @tomplus, @Jyhess, @slash-arun

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@richardwhiuk richardwhiuk requested a review from a user November 10, 2019 15:50
@richardwhiuk richardwhiuk removed the request for review from a user November 11, 2019 20:14
@spacether
Copy link
Contributor

spacether commented Jan 27, 2020

Python 2.7 end of life was Jan 1, 2020 per python/devguide#344
For now we will limit our syntax to 2.7 and higher syntax
If users want to use older versions of python with the generator, then they can customize the templates per @jimschubert's suggestion

In this issue: #4933
A plan has been laid out to remove python 2.X support and switch to Python3 only ~July 2020

@spacether spacether closed this Jan 27, 2020
@richardwhiuk richardwhiuk deleted the python-26-dict branch February 22, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants