Skip to content

[BugFix] Fix Biztoc With No Params #7056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

[BugFix] Fix Biztoc With No Params #7056

merged 1 commit into from
Mar 11, 2025

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

  2. What?:

    • Removes secondary request for additional general content when no param are supplied. This object has changed and no longer contains information consistent with the rest of the request.

  3. Impact:

    • obb.news.world(provider="biztoc") works again.

  4. Testing Done:

    • Test cassette is still valid because it uses a parameter.

Screenshot 2025-03-10 at 9 11 44 AM

@deeleeramone deeleeramone added bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4 labels Mar 10, 2025
@deeleeramone deeleeramone requested a review from piiq March 10, 2025 16:13
@piiq piiq added this pull request to the merge queue Mar 11, 2025
Merged via the queue into develop with commit 17521d6 Mar 11, 2025
12 checks passed
@piiq piiq deleted the bugfix/fix-biztoc branch March 29, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piiq piiq piiq approved these changes

Assignees
No one assigned
Labels
bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Unexpected Response Format From Biztoc News
2 participants
@deeleeramone @piiq