Skip to content

[BugFix] etf.sectors(provider='tmx') - Fix Key Error When No Info Found #7075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

deeleeramone
Copy link
Contributor

@deeleeramone deeleeramone commented Mar 24, 2025

  1. Why?:

    • KeyError caused by empty result.
    • Found a widget columnDef being defined as a date when it is a percent.
  2. What?:

    • Fixes KeyError
    • Narrows scope of date-like field type definitions by openbb-platform-api
  3. Impact:

    • Fixes bugs and improves accuracy.
  4. Testing Done:

    • You can check with:

      • `obb.etf.sectors("CASH", provider="tmx")
      • `obb.etf.info("CASH", provider="tmx")
    • Workspace backend widget, "Return YTD", was missing from a bar chart created by etf.info

      • etf.sectors was not returning None cleanly.
Screenshot 2025-03-24 at 12 15 36 PM

@deeleeramone deeleeramone added bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4 labels Mar 24, 2025
@deeleeramone deeleeramone requested a review from piiq March 24, 2025 19:24
@deeleeramone deeleeramone added this pull request to the merge queue Mar 24, 2025
Merged via the queue into develop with commit e1e28d6 Mar 24, 2025
9 checks passed
@piiq piiq deleted the bugfix/tmx-etf-sectors branch March 29, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants