Skip to content

[BugFix] Safely Access openapi_extra When None #7077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

deeleeramone
Copy link
Contributor

  1. Why?:

    • There were a couple of spots where openapi_extra was being accessed as a dictionary when the value was None.
  2. What?:

    • Fixes those instances to include the None check.
  3. Impact:

    • Custom extensions, Platform endpoints will have items in the openapi_extra slot.
  4. Testing Done:

    • Custom Router extension, create the function by directly accessing APIRouter instance.

@router._api_router.get("/get_data_choices")

@deeleeramone deeleeramone added bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4 labels Mar 26, 2025
@deeleeramone deeleeramone requested a review from piiq March 26, 2025 21:55
@deeleeramone deeleeramone added this pull request to the merge queue Mar 28, 2025
Merged via the queue into develop with commit e9c95b9 Mar 28, 2025
9 checks passed
@piiq piiq deleted the bugfix/commands-openapi branch March 29, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and bug fixes platform OpenBB Platform v4 PRs for v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants