Java9 fixes #181
Open
Java9 fixes #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgd
reviewed
May 23, 2025
| t.start(); | ||
|
|
||
| while (!lock.isBound()) { | ||
| Thread.sleep(10); |
There was a problem hiding this comment.
Consider replacing with Waiters.await... with an upper time bound to stop this hanging in CI if an error occurs
tgd
reviewed
May 23, 2025
| public static int currentProcessId() { | ||
| try { | ||
| // Java 9+ provides ProcessHandle which has a pid() method. | ||
| Class<?> phClass = Class.forName("java.lang.ProcessHandle"); |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This two-patch set brings better test coverage for
AffinityLockedge-cases and full Java 9+ compatibility across the project.1️⃣ New unit-tests
AffinityLockTestFileLockLockCheckTestLockCheckTestTotal: +49 LOC in
AffinityLockTestand +30 + lines in lock-checker tests.2️⃣ Java 9+ support & misc fixes
make-cnow activates only on Linux x86_64 (skips ARM and non-Linux builds).BootClassPathfalls back to walking the modularjrt:/filesystem whensun.boot.class.pathis absent (JDK 9+).Utilities.currentProcessId()usesProcessHandle.current().pid()when available; all PID calls routed through it (LockCheck,NullAffinity, macOS/Solaris impls, etc.).getProcessForCpu()on unsupported OS, uses new PID helper.Behavioural notes