Skip to content

ignore the gesdd failure on codspeed #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

ev-br
Copy link
Contributor

@ev-br ev-br commented Jul 2, 2024

An experiment to fish out the source of #4776 : cannot repro the error locally, let's see what the GH runners do

Temp ignore the sgesdd failure on codspeed, so that benchmark results upload.

@ev-br ev-br changed the title WIP: fish out the gesdd failure ignore the gesdd failure on codspeed Jul 3, 2024
In OpenMathLib#4776
we're hitting
** On entry to SLASCL parameter number  4 had an illegal value

on codspeed, but not outside (either locally or on github runners)
Copy link

codspeed-hq bot commented Jul 3, 2024

CodSpeed Performance Report

Merging #4777 will not alter performance

Comparing ev-br:sgesdd_ci_err (cd3c167) with develop (3677b38)

Summary

✅ 2 untouched benchmarks

🆕 60 new benchmarks
⁉️ 14 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop ev-br:sgesdd_ci_err Change
🆕 test_daxpy[100-c] N/A 24.4 µs N/A
🆕 test_daxpy[100-d] N/A 23.5 µs N/A
🆕 test_daxpy[100-s] N/A 23.7 µs N/A
🆕 test_daxpy[100-z] N/A 25.1 µs N/A
🆕 test_daxpy[1000-c] N/A 32 µs N/A
🆕 test_daxpy[1000-d] N/A 31.6 µs N/A
🆕 test_daxpy[1000-s] N/A 27 µs N/A
🆕 test_daxpy[1000-z] N/A 39.9 µs N/A
⁉️ test_daxpy[1000] 31 µs N/A N/A
⁉️ test_daxpy[100] 25.3 µs N/A N/A
🆕 test_dgbmv[1-100-c] N/A 39.2 µs N/A
🆕 test_dgbmv[1-100-d] N/A 36.8 µs N/A
🆕 test_dgbmv[1-100-s] N/A 36.1 µs N/A
🆕 test_dgbmv[1-100-z] N/A 40.9 µs N/A
🆕 test_dgbmv[1-1000-c] N/A 98.5 µs N/A
🆕 test_dgbmv[1-1000-d] N/A 82.6 µs N/A
🆕 test_dgbmv[1-1000-s] N/A 73.9 µs N/A
🆕 test_dgbmv[1-1000-z] N/A 117.7 µs N/A
🆕 test_dgemv[100-c] N/A 151.6 µs N/A
🆕 test_dgemv[100-d] N/A 145 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@martin-frbg martin-frbg merged commit acf0c3c into OpenMathLib:develop Jul 3, 2024
66 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants