Skip to content

Add pyi_out option to protoc command in the setup.py #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Jun 6, 2024

Reference to a related issue in the repository

#820

Add a description

Add pyi_out option to protoc command in the setup.py. This ways, IDEs recognize the modules and classes and autocorrect is supported:
image

image

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

@ClemensLinnhoff ClemensLinnhoff linked an issue Jun 6, 2024 that may be closed by this pull request
@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review June 6, 2024 12:35
@ClemensLinnhoff ClemensLinnhoff added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Jun 6, 2024
@ClemensLinnhoff ClemensLinnhoff self-assigned this Jun 6, 2024
@ClemensLinnhoff ClemensLinnhoff added this to the V3.7.1 milestone Jun 6, 2024
@pmai
Copy link
Contributor

pmai commented Jun 10, 2024

CCB 2024-06-10: Should be merged as soon as development on 3.7.1 starts. Inclusion into release 3.7.0 is deemed slightly too dangerous this close to release time, with potentially undetected bugs (even though fairly unlikely), want to make sure first-time PyPI release of 3.7.0 does not contain any breaking issues.

@yash-shah-asam
Copy link
Member

ASAM OSI CCB 2025-04-10: Approved and assigned to v3.7.1 and ready to be merged.

@asadekasam asadekasam added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels May 8, 2025
@pmai pmai force-pushed the 820-ide-not-recognizing-osi-classes-in-python branch from 6efa1fa to 985d326 Compare May 8, 2025 09:05
@pmai pmai merged commit d7640ca into master May 8, 2025
10 checks passed
@pmai pmai deleted the 820-ide-not-recognizing-osi-classes-in-python branch May 8, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE not recognizing OSI classes in python
6 participants