Skip to content
This repository was archived by the owner on Jan 21, 2022. It is now read-only.

Fix fmi installation and replace docker with explicit build #47

Merged
merged 5 commits into from
Feb 19, 2020

Conversation

vkresch
Copy link
Contributor

@vkresch vkresch commented Jan 21, 2020

Reference to a related issue in the repository

An issue occured during installation of the fmi library from the script build-install-build-deps.sh.

Add a description

What is this change?
This PR fixes the FMI installation in the script build-install-build-deps.sh. Furthermore I replace the docker osi-visualizer build with the explicit scripts which are provided by the repo for building the osi-visualizer to catch such errors in the issue in future. I also added the library libqt5opengl5-dev for the dependecy installation since the travis ci complained about it.

Mention a member

@jdsika @pmai pls review. Thanks!

Check the checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@vkresch vkresch added quality Quality improvements. bug Problems in the build system, build scripts, etc or faults in the interface. labels Jan 21, 2020
@jdsika jdsika requested a review from pmai January 21, 2020 11:40
@pmai pmai merged commit 3871055 into master Feb 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Problems in the build system, build scripts, etc or faults in the interface. quality Quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants