Update Our Team Page #1862 #1865
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 Changed routes:
Commit f70d615 (https://operation-code-wfub9tdg9-operation-code.vercel.app). |
|
Code Climate has analyzed commit f70d615 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 81.1% (-4.4% change). View more on Code Climate. |
operation_code
|
||||||||||||||||||||||||||||
| Project |
operation_code
|
| Branch Review |
pull/1865
|
| Run status |
|
| Run duration | 03m 14s |
| Commit |
|
| Committer | Cynthia S. Kao |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
25
|
| View all changes introduced in this branch ↗︎ | |
|
Hi folks @franciscusagnew Glomani Bravo-Lopez is not the Executive Director, please remove that title and add his photo if you can. Please also move him to the bottom as the newest member, and move Ali Cipolla-Taylor to beside me since she is the Vice-Chair. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updated Our Team Page info as requested in Issue #1862
Note:
Not able to update the photos in the request because someone with access to our Amazon S3 service needs to add them first. Once Cynthia's photo is added, its current link should work. However, for Glomani Bravo-Lopez the link will need to be added after the photo is uploaded.
Having bios of varying lengths causes the page to look inconsistent and disjointed. I will submit a request for a redesign to handle this problem in the interim.
Issue Resolved
Fixes #1862
Screenshots/GIFs