GH Actions: test workflow improvements #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is still a good idea to make sure the PHAR building script works on all supported PHP versions, it is not necessary to run this task against all PHP versions on all pushes, nor to have the test runs wait until all PHAR building builds are done, as for the tests we only need the PHARs generated on PHP 8.0, which are the ones used in a release. This commit splits the PHAR building job off to its own script, only keeping the PHAR build against PHP 8.0 in the `test` workflow. While this does mean there is now some duplication in the scripts, I find it more relevant to make the builds faster.
... which runs only against low/medium/high PHP versions and does not run: - the tests using custom PHP ini settings - the tests related to sniffs using external JS/CSS tooling - test CS check (integration test) using the PHAR This quick test workflow will now run on pushes to all branches except `master`. For pushes to `master`, the full test build will still be run. In the fast majority of cases, this quicktest will already surface any issues and it saves a lot of resources when the same builds don't run twice for every PR.
jrfnl
force-pushed
the
feature/ghactions-test-workflow-improvements
branch
from
c1a0772 to
fb7390e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GH Actions: split PHAR building task off to own script
While it is still a good idea to make sure the PHAR building script works on all supported PHP versions, it is not necessary to run this task against all PHP versions on all pushes, nor to have the test runs wait until all PHAR building builds are done, as for the tests we only need the PHARs generated on PHP 8.0, which are the ones used in a release.
This commit splits the PHAR building job off to its own script, only keeping the PHAR build against PHP 8.0 in the
testworkflow.While this does mean there is now some duplication in the scripts, I find it more relevant to make the builds faster.
GH Actions: introduce a quicktest workflow
... which runs only against low/medium/high PHP versions and does not run:
This quick test workflow will now run on pushes to all branches except
master. For pushes tomaster, the full test build will still be run.In the fast majority of cases, this quicktest will already surface any issues and it saves a lot of resources when the same builds don't run twice for every PR.
Suggested changelog entry
N/A