Squiz/ObjectInstantiation: remove keyword context test #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, this test was added in
squizlabs/PHP_CodeSniffer#836
as part of testing for allowing keywords to be used in other contexts (like
function names). This has been superseded in squizlabs/PHP_CodeSniffer#3484 to cover keywords used in different contexts in the core Tokenizer tests.
Live coding scenarios would not trigger this sniff as it only looks for
context before the 'new' keyword.
Description
Remove an unneeded test from
Squiz/Objects/ObjectInstantiation
that is no longer needed.The original check for
new
keyword used in other contexts is covered elsewhere in the core tokenizer tests.It is not needed as a parse error test for live coding either, as this sniff only looks for context before rather than after the
new
keyword.Suggested changelog entry
N/A
Related issues/external references
See #543 for discussion. Related to #143.
Types of changes
PR checklist