-
Notifications
You must be signed in to change notification settings - Fork 2.7k
add default state to checkbox inside textRun #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@ardabeyazoglu Could you rebase your PR, please ? |
Sure, I just rebased and pushed. |
2d9f999
to
e458249
Compare
Can we merge this now ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, yes. It's on the good way.
Could you test the Word 2007 modification ? And update the changelog, please ?
Thanks
src/PhpWord/Element/CheckBox.php
Outdated
* | ||
* @return self | ||
*/ | ||
public function setDefaultChecked(bool $default = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public function setDefaultChecked(bool $default = true) | |
public function setDefaultChecked(bool $default = true): self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can i update the changelog ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the test but i dont know why it fails only on 8.2
Description
When using textRun with templates, there is no possibility to set default checkbox state. This commit adds the possibility as shown below.
Fixes #1187 #696
Checklist:
composer run-script check --timeout=0
and no errors were reported