Smoke me/hv/sync bignum 20220412 #19624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[DELTA] * Improve upgrading and downgrading. This work is not complete. Some methods still don't downgrade when they should.
[DELTA] * Improve downgrading and upgrading.
[DELTA] * Restore the upgrading and downgrading in "bignum", with the exception of upgrading from Math::BigFloat to Math::BigRat, which I couldn't make sense of. Now, both integer literals and integers (and Infs and NaNs) that are the result of a computation become Math::BigInt objects, and both non-integer literals and non-integers that are as a result of a computation become Math::BigFloat objects. The classes used for literal integers and non-integers during compile-time are configurable, as well as the classes used for downgrading and upgrading during runtime. * Add the "bigfloat" pragma, which converts all numeric literals to Math::BigFloat objects. This is consistent with the "bigint" pragma, which converts all numeric literals to Math::BigInt objects, and the "bigrat" pragma which converts all numeric literals to Math::BigRat objects.
rjbs
force-pushed
the
smoke-me/hv/sync-bignum-20220412
branch
from
db04e54 to
ca3af6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rjbs @leonerd @neilb I'd like the PSC to consider merging this update to bignum-0.65, with associated updates to Math::BigInt and Math::BigRat.
This reverses the incompatible changes brought in with bignum-0.60 (which have not yet made it in to any public release of perl), and will fix #19539.
Smoke results (http://perl.develop-help.com/?b=smoke-me/hv/sync-bignum-20220412) look clean: the Solaris failures were also appearing in blead at that time, probably caused by the recent issue with
utils/zipdetails.