Skip to content

Move Agent Msgs to the SDK #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 6, 2023
Merged

Move Agent Msgs to the SDK #22

merged 7 commits into from
Dec 6, 2023

Conversation

eholum
Copy link
Contributor

@eholum eholum commented Dec 5, 2023

Moving these to the SDK to provide external callers to programmatic access to additional msgs used by the agent.

@eholum eholum self-assigned this Dec 5, 2023
@eholum eholum marked this pull request as draft December 5, 2023 16:41
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI build is currently failing:

#12 3.303 ERROR: the following packages/stacks could not have their rosdep keys resolved
#12 3.303 to system dependencies:
#12 3.303 moveit_studio_agent_msgs: Cannot locate rosdep definition for [moveit_task_constructor_msgs]

I think we need to copy over the agent msgs in the Dockerfile:

COPY moveit_studio_msgs/ src/moveit_studio_msgs/
COPY moveit_studio_py/ src/moveit_studio_py/

We should also add the agent msgs to the moveit_studio_msgs metapackage:

<depend>moveit_studio_sdk_msgs</depend>
<depend>moveit_studio_vision_msgs</depend>

@eholum
Copy link
Contributor Author

eholum commented Dec 5, 2023

Yes, I didn't fully audit message definitions so missed some dependencies. There's going to be more subtly here that is going to require breaking this package into two, those that require internal studio dependencies and those that don't. Right now it is exclusively the MTC solution manager stuff (I think), so I'll pull that out and get this building with it.

@eholum eholum marked this pull request as ready for review December 5, 2023 20:46
@eholum eholum requested a review from adlarkin December 5, 2023 20:46
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Before we merge this, take a look at my comments in the core Studio PR. I wonder if we want to add a few more messages/services to this package before merging.

Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a quick discussion elsewhere, this is ready to go 😁 :shipit:

Comment on lines 2 to 8
int8 ACTIVE = 0
int8 INACTIVE = 1
int8 SUSPENDED = 2
int8 EXPIRED = 3
int8 REVOKED = 4
int8 INET = 5
int8 UNKNOWN = 6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these double spaced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@eholum eholum merged commit 5e4aa03 into main Dec 6, 2023
@eholum eholum deleted the add-moveit-studio-agent-msgs branch December 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants