-
Notifications
You must be signed in to change notification settings - Fork 1
Move Agent Msgs to the SDK #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI build is currently failing:
#12 3.303 ERROR: the following packages/stacks could not have their rosdep keys resolved
#12 3.303 to system dependencies:
#12 3.303 moveit_studio_agent_msgs: Cannot locate rosdep definition for [moveit_task_constructor_msgs]
I think we need to copy over the agent msgs in the Dockerfile:
Lines 13 to 14 in b2b1994
COPY moveit_studio_msgs/ src/moveit_studio_msgs/ | |
COPY moveit_studio_py/ src/moveit_studio_py/ |
We should also add the agent msgs to the moveit_studio_msgs
metapackage:
moveit_studio_sdk/moveit_studio_msgs/moveit_studio_msgs/package.xml
Lines 12 to 13 in 8d4da42
<depend>moveit_studio_sdk_msgs</depend> | |
<depend>moveit_studio_vision_msgs</depend> |
Yes, I didn't fully audit message definitions so missed some dependencies. There's going to be more subtly here that is going to require breaking this package into two, those that require internal studio dependencies and those that don't. Right now it is exclusively the MTC solution manager stuff (I think), so I'll pull that out and get this building with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Before we merge this, take a look at my comments in the core Studio PR. I wonder if we want to add a few more messages/services to this package before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a quick discussion elsewhere, this is ready to go 😁
int8 ACTIVE = 0 | ||
int8 INACTIVE = 1 | ||
int8 SUSPENDED = 2 | ||
int8 EXPIRED = 3 | ||
int8 REVOKED = 4 | ||
int8 INET = 5 | ||
int8 UNKNOWN = 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are these double spaced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Moving these to the SDK to provide external callers to programmatic access to additional msgs used by the agent.