Skip to content

Refactor GraspableObject #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Refactor GraspableObject #55

merged 2 commits into from
Jul 25, 2024

Conversation

bgill92
Copy link
Contributor

@bgill92 bgill92 commented Jul 23, 2024

This PR refactors GraspableObject into CollisionObject, GraspInfo and ObjectColor to support: https://github.com/PickNikRobotics/moveit_studio/issues/7783.

Resolves https://github.com/PickNikRobotics/moveit_studio/issues/8020.

The CollisionObject portion of the message now contains all of the pertinent information about the rigid object that can be grasped, while GraspInfo contains information relevant to grasping. ObjectColor stays in GraspableObject because it doesn't belong in either CollisionObject or GraspInfo.

Here are the common fields between GraspableObject and CollisionObject:

std_msgs/Header header

geometry_msgs/Pose pose

string id

shape_msgs/SolidPrimitive[] primitives

geometry_msgs/Pose[] primitive_poses

shape_msgs/Mesh[] meshes

geometry_msgs/Pose[] mesh_poses

These fields are now consolidated in the object field of GraspableObject.

@bgill92 bgill92 requested a review from marioprats July 24, 2024 23:19
Copy link
Contributor

@marioprats marioprats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@bgill92 bgill92 merged commit c74719b into main Jul 25, 2024
2 checks passed
@bgill92 bgill92 deleted the pr-refactor-GraspableObject branch July 25, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants