Skip to content

[UPD] Status checks #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---

# These are supported funding model platforms

github: Plaenkler
16 changes: 15 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,18 @@ updates:
- package-ecosystem: "gomod"
directory: "/"
schedule:
interval: "daily"
interval: "daily"
target-branch: "dependencies"
assignees:
- "Plaenkler"
reviewers:
- "Plaenkler"
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
target-branch: "dependencies"
assignees:
- "Plaenkler"
reviewers:
- "Plaenkler"
37 changes: 8 additions & 29 deletions .github/linters/.golangci.yml
Original file line number Diff line number Diff line change
@@ -1,27 +1,18 @@
---

run:
concurrency: 4
timeout: 240s
issues-exit-code: 2
tests: false
go: '1.20'
timeout: 60s

linters:
# start with everything
enable-all: true

disable:
# deprecated
- golint
- interfacer
- maligned
- scopelint
- deadcode
- varcheck
- structcheck

# too annoying
- cyclop
- exhaustive
- exhaustivestruct
Expand All @@ -30,7 +21,8 @@ linters:
- funlen
- gochecknoglobals
- godot
- goerr113
- err113
- gofmt
- gofumpt
- gomnd
- lll
Expand All @@ -41,25 +33,15 @@ linters:
- varnamelen
- wsl
- nonamedreturns
- depguard

# review later
- gofmt
- goimports

# complexity linters
- contextcheck
- gocognit
- gocyclo
- maintidx

# i disagree with these
- wrapcheck
- nolintlint
- errorlint
- noctx
- gochecknoinits

# should not block the build
- prealloc
- godox
- dupl
Expand All @@ -68,19 +50,16 @@ linters:
- nilerr
- ireturn
- nosprintfhostport

# buggy
- depguard
- gci

# this breaks with proto generation
- nosnakecase

# disabled because of generics
- rowserrcheck
- sqlclosecheck
- structcheck
- wastedassign
- goimports
- mnd

linters-settings:
wsl:
allow-cuddle-declarations: true
allow-cuddle-declarations: true
38 changes: 0 additions & 38 deletions .github/workflows/codeql.yml

This file was deleted.

38 changes: 31 additions & 7 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,44 @@ on:
pull_request:
branches: main

permissions:
contents: read
packages: read
statuses: write

jobs:
build:
name: Lint Code Base
super-linter:
name: Lint Multiple
runs-on: ubuntu-latest

steps:
- name: Checkout Code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Lint Code Base
uses: super-linter/super-linter@v5
uses: super-linter/super-linter/slim@v6
env:
DEFAULT_BRANCH: main
VALIDATE_ALL_CODEBASE: true
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
VALIDATE_ALL_CODEBASE: true
VALIDATE_JSCPD: false
VALIDATE_GO: false
VALIDATE_GO_MODULES: false
golangci-lint:
name: Lint Golang
runs-on: ubuntu-latest
steps:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: 1.22
- name: Checkout Code
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install dependencies
run: go mod tidy
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v6
with:
args: --timeout=3m
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ Plaenkler/Booklooker enables HTTP requests to be made to the [Booklooker API](ht

<table style="border:none;">
<tr>
<td><img src="https://user-images.githubusercontent.com/60503970/217090657-d8d08ec3-fe4b-45ec-ab10-d48f767c4695.png" width="480"/></td>
<td><img src="https://user-images.githubusercontent.com/60503970/217090678-891a25b7-0b06-41fe-bbf5-f3933f81bef5.png" width="480"/></td>
<td><img src="https://user-images.githubusercontent.com/60503970/217090657-d8d08ec3-fe4b-45ec-ab10-d48f767c4695.png" alt="delete article example" width="480"/></td>
<td><img src="https://user-images.githubusercontent.com/60503970/217090678-891a25b7-0b06-41fe-bbf5-f3933f81bef5.png" alt="import file example" width="480"/></td>
</tr>
</table>

Expand Down
Loading