refactor: no middleware for response logging #4062
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benefits: - Removes `unsafePerformIO` from Logger - Reuses our cached time getter (`stateGetZTime`) instead of having another unnecessary one. See https://github.com/yesodweb/wai//blob/d50e1184600631a114e3d2ad119abdf0ef08834b/wai-extra/Network/Wai/Middleware/RequestLogger/Internal.hs#L22-L37. - Reuses Observation module, simplified logic - Will help with log buffering PostgREST#4061 TODO: - [ ] Currently we vendor `apacheLogStr`, but might be possible to expose this function upstream. If not, it's not a big problem since the function is small. - [ ] Time in logging differs a bit: ``` Old: postgrest_test_anonymous [04/May/2025:14:43:06 -0500] New: postgrest_test_anonymous [2025-05-04 22:43:01.28098247 -05] ``` + Otherwise all logging works the same. - [ ] Auth error logging relies on old logger middleware + We might need to put `observer` in Auth.hs + Or otherwise try to combine this with PostgREST#4059
|
Looks good 👍. I was thinking of adding some commits to this PR to quickly wrap this one up, but I am not sure how to do that. |
@taimoorzaeem That would be great! Maybe you can open another PR based on this one? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits:
unsafePerformIOfrom LoggerstateGetZTime) instead of having another unnecessary one. See https://github.com/yesodweb/wai//blob/d50e1184600631a114e3d2ad119abdf0ef08834b/wai-extra/Network/Wai/Middleware/RequestLogger/Internal.hs#L22-L37.TODO:
apacheLogStr, but might be possible to expose this function upstream. If not, it's not a big problem since the function is small.observerin Auth.hs