Bugfix/fix clang cl #276
Merged
Bugfix/fix clang cl #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
mgovers
force-pushed
the
bugfix/fix-clang-cl
branch
from
740767f to
f56f873
Compare
mgovers
commented
Jun 20, 2023
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
TonyXiang8787
approved these changes
Jun 22, 2023
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #241
Changes proposed in this PR include:
It was found that in #241 the culprit was the fact that the
trait_pointer_to_memberstruct pointed to the wrong member variable in the memory layout. Maybe this was caused by some different memory or template overload order when dealing with inheritanceOverloading the template with a
requiresblock that only generates the template when the provided base class is identical to the identified base class fixes this template choice mismatchCould you please pay extra attention to the points below when reviewing the PR:
Please try to repro this on your local machine (build with Clang CL Debug/Release + run all tests)
Testing
I did a matrix test on my computer using
[msvc, clang-cl] x [debug, release]with clean reconfigure and clean rebuild all targets and all tests passed after this change(note: before this change, i verified that the bug in #241 was still there, so the change actually fixed the tests)