-
Notifications
You must be signed in to change notification settings - Fork 1.2k
DeprecationWarning when import monai #8060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Some new warning:
|
Signed-off-by: YunLiu <[email protected]>
- add packaging in setup.cfg - fix test_gdsdataset.py issue - add test_matshow3d to the skip list for min test - suppress deprecated warning when import monai (workaround for #8060) ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <[email protected]> Co-authored-by: Eric Kerfoot <[email protected]>
- add packaging in setup.cfg - fix test_gdsdataset.py issue - add test_matshow3d to the skip list for min test - suppress deprecated warning when import monai (workaround for Project-MONAI#8060) ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <[email protected]> Co-authored-by: Eric Kerfoot <[email protected]>
Hi @KumoLiu are these still current warnings that we need to look at? I think the Numpy related ones are obsolete now. |
Hi @ericspod, in this PR I've suppressed these warnings, so it should be fine for now. Since these warnings are not originating from the MONAI core itself, let's keep the suppression as it is for now. What do you think? We can close this ticket or leave it as a reminder. Both should be fine to me. Line 54 in 4986d7f
|
I think we leave things as they are with the warnings suppressed and we will revisit this later. |
Uh oh!
There was an error while loading. Please reload this page.
The text was updated successfully, but these errors were encountered: