Skip to content

fixes issue of typing with py3.6 #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 5, 2021
Merged

fixes issue of typing with py3.6 #1942

merged 13 commits into from
Apr 5, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Apr 5, 2021

part of #1889

Description

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.

wyli added 8 commits April 5, 2021 00:51
@wyli
less warning msg; remove PILImage types
adcd6df 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
remove engine type
1dab64a 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
temp tests
3e8d8f4 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
add quick py36 37 tests
ac3dca5 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
temp tests
deaed40 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Revert "temp tests"
9020192 
This reverts commit deaed40.

Signed-off-by: Wenqi Li <[email protected]>
@wyli
Revert "temp tests"
48011dd 
This reverts commit 3e8d8f4.

Signed-off-by: Wenqi Li <[email protected]>
@wyli
min test exclude senet test
a3f6f7a 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested a review from Nic-Ma April 5, 2021 00:54
wyli added 3 commits April 5, 2021 01:57
@wyli
update
6925782 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
temp test
3976ddf 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Revert "temp test"
a81ba2a 
This reverts commit 31f40a0.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the debug-release-rc branch from 4ab6bdc to a81ba2a Compare April 5, 2021 00:58
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Apr 5, 2021

Hi @IsaacYangSLA and @madil90 ,

Could you please help review this PR? This is an urgent fix for MONAI v0.5 release.

Thanks.

wyli added 2 commits April 5, 2021 02:43
@wyli
update get gpu id
db327d7 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
update docsstrings
c51cea7 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli enabled auto-merge (squash) April 5, 2021 01:48
@wyli wyli merged commit da3240f into master Apr 5, 2021
@wyli wyli deleted the debug-release-rc branch April 5, 2021 02:21
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
@wyli @nsrivathsa
fixes issue of typing with py3.6 (Project-MONAI#1942)
4c2894d 
* less warning msg; remove PILImage types

Signed-off-by: Wenqi Li <[email protected]>

* remove engine type

Signed-off-by: Wenqi Li <[email protected]>

* temp tests

Signed-off-by: Wenqi Li <[email protected]>

* add quick py36 37 tests

Signed-off-by: Wenqi Li <[email protected]>

* temp tests

Signed-off-by: Wenqi Li <[email protected]>

* Revert "temp tests"

This reverts commit deaed40.

Signed-off-by: Wenqi Li <[email protected]>

* Revert "temp tests"

This reverts commit 3e8d8f4.

Signed-off-by: Wenqi Li <[email protected]>

* min test exclude senet test

Signed-off-by: Wenqi Li <[email protected]>

* update

Signed-off-by: Wenqi Li <[email protected]>

* temp test

Signed-off-by: Wenqi Li <[email protected]>

* Revert "temp test"

This reverts commit 31f40a0.

Signed-off-by: Wenqi Li <[email protected]>

* update get gpu id

Signed-off-by: Wenqi Li <[email protected]>

* update docsstrings

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyli @Nic-Ma