Skip to content

1939 Add strict_shape option in CheckpointLoader #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 5, 2021
Merged

1939 Add strict_shape option in CheckpointLoader #1946

merged 4 commits into from
Apr 5, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Apr 5, 2021 •
edited
Loading

Fixes #1939 .

Description

This PR added the strict_shape option to the CheckpointLoader handler.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma changed the title [WIP] 1939 Add strict_shape option in CheckpointLoader 1939 Add strict_shape option in CheckpointLoader Apr 5, 2021
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 5, 2021

/black

@Nic-Ma Nic-Ma requested review from wyli, ericspod and rijobro April 5, 2021 16:06
@Nic-Ma Nic-Ma marked this pull request as ready for review April 5, 2021 16:07
Nic-Ma and others added 4 commits April 5, 2021 19:10
@wyli wyli force-pushed the 1939-add-strict-shape branch from e746a53 to b406974 Compare April 5, 2021 18:10
wyli
wyli approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a non-breaking change

@wyli wyli enabled auto-merge (squash) April 5, 2021 18:44
@wyli wyli merged commit f1db865 into Project-MONAI:master Apr 5, 2021
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
@Nic-Ma @wyli @nsrivathsa
1939 Add strict_shape option in CheckpointLoader (Project-MONAI#1946)
5e7be9b 
* [DLMED] add strict_shape option

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] add unit tests

Signed-off-by: Nic Ma <[email protected]>

* update test case

Signed-off-by: Wenqi Li <[email protected]>

* fixes test config

Signed-off-by: Wenqi Li <[email protected]>

Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
@Nic-Ma Nic-Ma deleted the 1939-add-strict-shape branch July 2, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add strict_shape option to CheckpointLoader
2 participants
@Nic-Ma @wyli