Skip to content

Update garbage collection assertion #1959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Update garbage collection assertion #1959

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60d3fe2
Update garbage collection assertion to a more reliable one
bhashemian Apr 7, 2021
3973881
Remove print
bhashemian Apr 7, 2021
208db04
Merge branch 'master' into update_garbage_testing
wyli Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions tests/test_handler_garbage_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,17 +60,16 @@ def _train_func(engine, batch):
GarbageCollector(trigger_event=trigger_event, log_level=30).attach(engine)

engine.run(data_loader, max_epochs=5)
print(gb_count_dict)

first_count = 0
for epoch, gb_count in gb_count_dict.items():
# At least one zero-generation object
for iter, gb_count in gb_count_dict.items():
# At least one zero-generation object is collected
self.assertGreater(gb_count[0], 0)
if epoch == 1:
first_count = gb_count[0]
else:
# The should be less number of collected objects in the next calls.
self.assertLess(gb_count[0], first_count)
if iter > 1:
# Since we are collecting all objects from all generations manually at each call,
# starting from the second call, there shouldn't be any 1st and 2nd generation objects available to collect.
self.assertEqual(gb_count[1], first_count)
self.assertEqual(gb_count[2], first_count)


if __name__ == "__main__":
Expand Down