Skip to content

1965 - register_backward_hook #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Apr 7, 2021

Fixes #1965

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.

@wyli wyli requested review from Nic-Ma and rijobro April 7, 2021 15:09
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 1965-fixes-register_backward_hook branch from 86a0781 to 582715d Compare April 7, 2021 17:35
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 1965-fixes-register_backward_hook branch from 582715d to 5cc1fe0 Compare April 7, 2021 17:38
@wyli wyli enabled auto-merge (squash) April 7, 2021 21:17
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@ericspod could you please help also review this PR?

Thanks.

@wyli wyli merged commit 8cbd59a into Project-MONAI:master Apr 7, 2021
@wyli wyli deleted the 1965-fixes-register_backward_hook branch April 12, 2021 14:18
nsrivathsa pushed a commit to nsrivathsa/MONAI that referenced this pull request Apr 12, 2021
* fixes Project-MONAI#1965

Signed-off-by: Wenqi Li <[email protected]>

* adds docstring

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
@ericspod
Copy link
Member

I saw your comment @Nic-Ma just now. This looks correct to me given the replaced method being deprecated in Pytorch 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

register_backward_hook is deprecating in torch 1.8
3 participants