Skip to content

[WIP] Adding Stain Normalization Transform for Pathology #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 36 commits into from

Conversation

nsrivathsa
Copy link
Contributor

@nsrivathsa nsrivathsa commented Apr 13, 2021

Description

Adds a Transform for CuPy-based Stain Normalization for Pathology.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Neha Srivathsa <[email protected]>
@nsrivathsa nsrivathsa marked this pull request as ready for review April 13, 2021 03:23
@bhashemian bhashemian self-requested a review April 13, 2021 04:01
@bhashemian bhashemian changed the title [WIP] Adding Stain Normalization Transform for Pathology (2) [WIP] Adding Stain Normalization Transform for Pathology Apr 13, 2021
Copy link
Member

@bhashemian bhashemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, @nsrivathsa! I left few comments inline.
In general, can you think of edge cases in physical world for test cases as well, like the situation that we expect to have only one stain so the concentration of the other one is zero.
Also it would be great to have input images that are not uniformly filled.
Keep in mind that writing solid unittests are very important to ensure the correctness of our code and it might take more time than implementing the original functions and classes.

Signed-off-by: Neha Srivathsa <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
Signed-off-by: Neha Srivathsa <[email protected]>
@nsrivathsa nsrivathsa requested a review from bhashemian April 19, 2021 23:42
@bhashemian
Copy link
Member

@nsrivathsa I see that lines 47-75 for stain extraction are being repeated in line 143-171 for stain normalization. Can you modify the code so that it reuses stain extraction in stain normalization?

@bhashemian bhashemian force-pushed the neha/stain-norm-2 branch from 5294bf2 to be88f7d Compare May 3, 2021 16:31
@bhashemian bhashemian marked this pull request as draft July 9, 2021 16:30
@madil90
Copy link
Contributor

madil90 commented Jul 19, 2021

/build

@bhashemian bhashemian mentioned this pull request Jul 28, 2021
6 tasks
@bhashemian
Copy link
Member

A variant of this PR is merged.

@bhashemian bhashemian closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants