Skip to content

Reorganize datasets and metrics in pathology #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

bhashemian
Copy link
Member

@bhashemian bhashemian commented Aug 10, 2021

Description

This PR reorganize pathology-related datasets and metrics into directories similar to main MONAI.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

@madil90
Copy link
Contributor

madil90 commented Aug 10, 2021

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is mostly non-breaking, looks good to me -- please confirm @Nic-Ma

@bhashemian
Copy link
Member Author

thanks, this is mostly non-breaking, looks good to me -- please confirm @Nic-Ma

Thanks, @wyli! That's correct, they are essentially non-breaking changes but they just affect the way to import them.

@Nic-Ma Nic-Ma merged commit ce4960d into Project-MONAI:dev Aug 10, 2021
@bhashemian bhashemian deleted the reorganize-pathology branch August 10, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants