Skip to content

2743 - no extension check for user specified reader #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 13, 2021
Merged

2743 - no extension check for user specified reader #2751

merged 8 commits into from
Aug 13, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Aug 11, 2021 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, rijobro and ericspod August 11, 2021 18:52
@wyli
fixes mypy issue
d58b955 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor Author

wyli commented Aug 11, 2021 •
edited
Loading

/integration-test
/black

@wyli wyli marked this pull request as ready for review August 11, 2021 20:41
@wyli
adds tests and docs
2ad2512 
Signed-off-by: Wenqi Li <[email protected]>
@madil90
Copy link
Contributor

madil90 commented Aug 12, 2021

/build

@wyli
fixes test
9fcce6a 
Signed-off-by: Wenqi Li <[email protected]>
Nic-Ma
Nic-Ma reviewed Aug 12, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for minor comments.

Thanks.

@wyli
adds reader args kwargs
37d77a8 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli enabled auto-merge (squash) August 12, 2021 10:36
@wyli wyli merged commit a7d4574 into Project-MONAI:dev Aug 13, 2021
@wyli wyli deleted the 2743-loadimage branch November 18, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LoadImage can not read .mgz files LoadImage and SaveImage is unable to handle pathlib.Path
3 participants
@wyli @madil90 @Nic-Ma