Skip to content

233 - set up a backward compatibility policy #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 11, 2022
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Aug 8, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #233

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from ericspod, Nic-Ma and rijobro August 8, 2022 12:11
@wyli wyli marked this pull request as ready for review August 9, 2022 20:46
@wyli wyli requested a review from ericspod August 9, 2022 21:40
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Put minor comments inline.

Thanks.

@wyli
Copy link
Contributor Author

wyli commented Aug 11, 2022

/build

@wyli wyli enabled auto-merge (squash) August 11, 2022 10:31
@wyli wyli merged commit b1ccd02 into Project-MONAI:dev Aug 11, 2022
@wyli wyli deleted the bc-policy branch August 11, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up an explicit backward compatibility policy
3 participants