Skip to content

feat: Bridge Command Events #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 12, 2023
Merged

feat: Bridge Command Events #1916

merged 9 commits into from
Feb 12, 2023

Conversation

OmLanke
Copy link
Contributor

@OmLanke OmLanke commented Feb 10, 2023 •
edited
Loading

Summary

Adds on_bridge_command, on_bridge_command_completion and on_bridge_command_error

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@JustaSqu1d JustaSqu1d added status: in progress Work in Progess feature Implements a feature ext.bridge Relating to ext.bridge python labels Feb 10, 2023
@OmLanke OmLanke changed the title Bridge Command Events feat: Bridge Command Events Feb 10, 2023
JustaSqu1d
JustaSqu1d reviewed Feb 10, 2023
View reviewed changes
Copy link
Member

@JustaSqu1d JustaSqu1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry.

@OmLanke OmLanke marked this pull request as ready for review February 11, 2023 02:51
@OmLanke OmLanke requested review from a team as code owners February 11, 2023 02:51
JustaSqu1d
JustaSqu1d suggested changes Feb 11, 2023
View reviewed changes
@JustaSqu1d JustaSqu1d requested a review from Lulalaby February 11, 2023 16:37
@Lulalaby Lulalaby enabled auto-merge (squash) February 12, 2023 05:02
@Lulalaby Lulalaby merged commit 3b762f9 into Pycord-Development:master Feb 12, 2023
BobDotCom added a commit that referenced this pull request Feb 16, 2023
@BobDotCom
docs(changelog): fix changelog entry for #1916
4a1b994 
Signed-off-by: BobDotCom <[email protected]>
BobDotCom added a commit that referenced this pull request Mar 20, 2023
@BobDotCom
docs(changelog): fix changelog entry for #1916
c47cecf 
Signed-off-by: BobDotCom <[email protected]>
@OmLanke OmLanke deleted the bridge_command_error branch March 25, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lulalaby Lulalaby Lulalaby approved these changes

@Middledot Middledot Middledot approved these changes

@JustaSqu1d JustaSqu1d JustaSqu1d approved these changes

Assignees
No one assigned
Labels
ext.bridge Relating to ext.bridge feature Implements a feature status: in progress Work in Progess
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OmLanke @Lulalaby @Middledot @JustaSqu1d