Skip to content

Updated to be compatible with Android 26 or higher without need of java.util.Calendar #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

jlurena
Copy link

@jlurena jlurena commented Jul 15, 2018

  • Removed java.util.Calendar Dependency
  • Removed Support Library Dependencies
  • Updated build tools
  • Updated Target SDK to 28, Android P

NOTE I do not want to merge into Develop (if its the main branch). I would just like a branch that can be driven by the community for Applications that only support Android 26 or higher, without the need of Support Libraries etc.

@AndroidDeveloperLB
Copy link

Really wish you had tried to work on my fork instead, as I've converted it to Kotlin, fixed a lot of issues, and added a few more features:
https://github.com/AndroidDeveloperLB/Android-Week-View

But according to what I see on your changes, you've raised the minSdk quite a lot. API 26 is only available to 5.7% of users out there, according to Android dashboard website:
https://developer.android.com/about/dashboards/

I would suggest other types of optimizations instead. One of them is to try to reduce number of instance creations of all classes upon drawing of the View, especially instances of Calendar class.

@jlurena jlurena closed this Jul 21, 2018
@jlurena jlurena deleted the android26_update branch July 21, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants