Proposed fix for Issue 53 - use bool OnDataReceived signal to avoid i… #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndefinite recursion
|
Will also likely fix occurrences of #44 since it may eliminate the multiple exceptions related to failure upon too many threads |
|
Next release will be on 16 April 2018. |
|
Yes, but then we have to figure out another way to stop the indefinite recursion that's going on. I haven't looked at the tests - maybe they need to be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may resolve Issue #53 . Since PollingXHR.Create's Task.Run may never finish due to recursive calls due to incoming data, this tries to use bool OnDataReceived as a signal to the DoPoll function, limiting recursion.