Skip to content

ros2 service replier #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amfern
Copy link

@amfern amfern commented Dec 28, 2020

Implements ROS2 service

@amfern
Copy link
Author

amfern commented Dec 28, 2020

This resolves #51

@amfern
Copy link
Author

amfern commented Jan 13, 2021

ping @OpusK, hey can you take a look?

@per1234
Copy link
Contributor

per1234 commented Feb 2, 2021

Regarding this CI failure:
https://travis-ci.org/github/ROBOTIS-GIT/ros2arduino/builds/751887104#L405

In file included from /home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/SafeRingBuffer.h:25:0,
                 from /home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/Uart.h:23,
                 from /home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/variants/mkr1000/variant.h:164,
                 from /home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/Arduino.h:48,
                 from sketch/subscriber.ino.cpp:1:
/home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/sync.h:28:22: error: expected unqualified-id before 'for'
 #define synchronized for (__Guard __guard; __guard.enter(); )
                      ^
/home/travis/arduino_ide/libraries/ros2arduino/src/ros2/xrcedds/micro_xrce_dds/lib/include/uxr/client/core/session/session.h:97:10: note: in expansion of macro 'synchronized'
     bool synchronized;
          ^~~~~~~~~~~~
/home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/sync.h:28:44: error: '__guard' does not name a type; did you mean '__Guard'?
 #define synchronized for (__Guard __guard; __guard.enter(); )
                                            ^
/home/travis/arduino_ide/libraries/ros2arduino/src/ros2/xrcedds/micro_xrce_dds/lib/include/uxr/client/core/session/session.h:97:10: note: in expansion of macro 'synchronized'
     bool synchronized;
          ^~~~~~~~~~~~
/home/travis/.arduino15/packages/arduino/hardware/samd/1.8.11/cores/arduino/sync.h:28:61: error: expected unqualified-id before ')' token
 #define synchronized for (__Guard __guard; __guard.enter(); )
                                                             ^
/home/travis/arduino_ide/libraries/ros2arduino/src/ros2/xrcedds/micro_xrce_dds/lib/include/uxr/client/core/session/session.h:97:10: note: in expansion of macro 'synchronized'
     bool synchronized;
          ^~~~~~~~~~~~
exit status 1

It has been reported here: arduino/ArduinoCore-samd#596
I don't think it is related to the changes made in this pull request in any way. It's simply that the breakage was introduced in the 1.8.11 release of the Arduino SAMD Boards platform on 2020-12-24, which came after the last CI run, but before this PR was submitted. If you compile the ros2arduino code from the master branch with Arduino SAMD Boards 1.8.11 you'll get the same error.

@OpusK
Copy link
Contributor

OpusK commented Mar 17, 2021

@amfern Sorry for the late.

Unfortunately, I no longer have administrative rights to this repo...

@amfern
Copy link
Author

amfern commented Mar 17, 2021

Thanks for coming back, i learn alot when tinckering with this repo. And i already moved on to micro_ros_arduino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants