-
Notifications
You must be signed in to change notification settings - Fork 199
Fix amd_ck_fp8.hpp macro definitions #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xli
wants to merge
8
commits into
ROCm:develop
Choose a base branch
from
xli:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove CK_USE_FNUZ_FP8 and CK_USE_OCP_FP8 definitions, they are default behavior of preprocessor before compilation. Undefined macro is replaced with 0 when used in #if. In rocm 6.4, there is rocm/6.4.0/include/ck/config.h header file defines both CK_USE_FNUZ_FP8 and CK_USE_OCP_FP8, the current definition inside amd_ck_fp8.hpp will cause macro-redefined error. 2. Prefix __assert_fnuz_support and __assert_ocp_support with namespace fp8_impl to avoid redefined error when building with rocm 6.4+ (rocm/6.4.0/include/hip/amd_detail/amd_hip_fp8.h)
1. Remove CK_USE_FNUZ_FP8 and CK_USE_OCP_FP8 definitions, they are default behavior of preprocessor before compilation. Undefined macro is replaced with 0 when used in #if. In rocm 6.4, there is rocm/6.4.0/include/ck/config.h header file defines both CK_USE_FNUZ_FP8 and CK_USE_OCP_FP8, the current definition inside amd_ck_fp8.hpp will cause macro-redefined error. 2. Prefix __assert_fnuz_support and __assert_ocp_support with namespace fp8_impl to avoid redefined error when building with rocm 6.4+ (rocm/6.4.0/include/hip/amd_detail/amd_hip_fp8.h)
@andriy-ca what is broken now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist
Please put an
x
into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-format
on all changed files