Skip to content

[menuconfig] Add env file for fish #8026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

1ridic
Copy link
Contributor

@1ridic 1ridic commented Sep 11, 2023

Using env.sh in fish shell will cause
problems. Creating a new env.fish for it.

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

env 中缺失对 fish shell 的支持。

你的解决方案是什么 (what is your solution)

添加一个新的 env.fish 文件以支持在 fish 中使用 source 引入环境变量。

在什么测试环境下测试通过 (what is the test environment)

在本机中进行测试通过,可以正常引入环境变量。

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

Using env.sh in fish shell will cause
problems. Creating a new env.fish for it.
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2023

CLA assistant check
All committers have signed the CLA.

@Guozhanxin
Copy link
Member

Thank you for your contribution, please sign the CLA.

@1ridic
Copy link
Contributor Author

1ridic commented Sep 12, 2023

Signed.

@zhkag
Copy link
Member

zhkag commented Sep 14, 2023

已验证可行,不过应该有方法去判断当前 shell 是不是 fish,然后再去生成 fish 的配置文件,按照这样的方式改一下吧

@1ridic
Copy link
Contributor Author

1ridic commented Sep 14, 2023

逻辑改为:如果存在 fish 的配置文件,就额外生成一个 env.fish 文件

@zhkag zhkag requested a review from Guozhanxin September 14, 2023 06:22
@zhkag zhkag added the +1 Agree +1 label Sep 14, 2023
@mysterywolf mysterywolf merged commit ec9bbac into RT-Thread:master Sep 14, 2023
@mysterywolf
Copy link
Member

能在论坛写个文章简单介绍一下fish shell怎么用env嘛

@1ridic
Copy link
Contributor Author

1ridic commented Sep 14, 2023

使用方法上是一样的,只是 fish shell 不完全支持 bash 的语法,所以用 fish 的语法生成一个文件用于包含环境变量

@mysterywolf
Copy link
Member

麻烦简单写一下怎么用fish shell建立env环境,比如我,并不清楚这个怎么搭建env配置和编译环境

@1ridic
Copy link
Contributor Author

1ridic commented Sep 15, 2023

可以的,我找时间写一个

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants