🎈 perf: perf rt_hw_interrupt_disable/enable #8042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xqyjlj
requested review from
Guozhanxin,
BernardXiong and
mysterywolf
as code owners
|
需要rebase一下代码 有冲突 |
BernardXiong
requested changes
Sep 16, 2023
Guozhanxin
added
the
v5.1.0
xqyjlj
force-pushed
the
perf-dev
branch
5 times, most recently
from
a9c783f to
84f98ca
Compare
|
|
一个是需要解决代码冲突，另外前向需要合并的关联PR也列出来吧 |
xqyjlj
force-pushed
the
perf-dev
branch
2 times, most recently
from
22c2402 to
fe2be07
Compare
可以合并了 |
Guozhanxin
reviewed
Oct 19, 2023
Guozhanxin
reviewed
Oct 19, 2023
Guozhanxin
reviewed
Oct 19, 2023
Guozhanxin
reviewed
Oct 19, 2023
Guozhanxin
reviewed
Oct 19, 2023
Guozhanxin
approved these changes
Oct 19, 2023
BernardXiong
requested changes
Oct 20, 2023
|
关于c++的原子类型，如果在c++中启用原子类型，那么 #ifdef __cplusplus
#include <atomic> // atomic 要在extern "C" {前面，导致rtdef.h也不能被extern "C"包含
extern "C" {
#endif
typedef std::atomic<size_t> rt_atomic_t;还有一种是c++的原子操作用硬件原子或者软件模拟原子替换，这样就是和c语言的一样的实现了 |
|
还有一种c++的原子类型兼容是把c++的原子通过宏重定向到软件原子或者硬件原子，undef 掉RT_USING_STDC_ATOMIC，这样就不会包含stdatomic.h引起编译报错了 |
xqyjlj
force-pushed
the
perf-dev
branch
3 times, most recently
from
7aa38c9 to
7a9f812
Compare
skychen123
approved these changes
Oct 24, 2023
xqyjlj
force-pushed
the
perf-dev
branch
3 times, most recently
from
21fff9c to
8b6da61
Compare
BernardXiong
approved these changes
Oct 25, 2023
Including usages under lwp_pid.c, lwp_tid.c, lwp_signal.c, lwp_syscall.c, lwp_pmutex.c, lwp.c. 2 API for safety mutex take are provided - lwp_mutex_take_safe/lwp_mutex_release_safe. They will restrict and verify the usage of the mutex. Remove the hw_interrupt API in ipc.c, and switch to spin lock for synchronization. Signed-off-by: Shell <[email protected]>
a1012112796
reviewed
Nov 14, 2023
Comment on lines
+700
to
702
| rt_spin_unlock_irqrestore(&_hard_spinlock, level); | ||
| /* call timeout function */ | ||
| t->timeout_func(t->parameter); |
There was a problem hiding this comment.
个人还是不是很理解 timeout_func 前后恢复中断状态的方案，虽然它确实在理论上对提升实时性有很大帮助。个人理解，在遍历 _timer_list 的前后关中断，不就是为了确保其它线程或者中断环境不会对 _timer_list 做任何修改吗? 而此处开启中断， 但不出现问题，是否意味着其它线程或者中断环境可以在此阶段修改 timer_list, 遍历 _timer_list 的逻辑不会被影响? 那在这个函数中关中断的意义何在?
There was a problem hiding this comment.
如果中断中使用了timer相关的api，是会修改timer_list，而且可能会插到链表前面去，造成漏掉一个时钟节拍。这个确实需要考虑。
9 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
优化调度器，优化大量大锁代码, RT_USING_SIGNALS 由于环境原因，目前暂未优化
你的解决方案是什么 (what is your solution)
在什么测试环境下测试通过 (what is the test environment)
arm64
arm
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up