fix(Pandora - Disable ads): Support latest app target #5185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
patches/src/main/kotlin/app/revanced/patches/pandora/misc/EnableUnlimitedSkipsPatch.kt
Outdated
Show resolved
Hide resolved
|
Should a version constrain be added? The first version lasted only a week or two before it broke, and this app is still very new for patches. |
LisoUseInAIKyrios
changed the title
Disable ads patch
oSumAtrIX
reviewed
Jun 16, 2025
patches/src/main/kotlin/app/revanced/patches/pandora/misc/EnableUnlimitedSkipsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Jun 16, 2025
patches/src/main/kotlin/app/revanced/patches/pandora/ads/Fingerprints.kt
Outdated
Show resolved
Hide resolved
|
The patch looks simple enough. If it breaks again though it can be constrained to a versionn |
Patch should be backwards compatible too. The method I'm patching was in the previous version, so not sure what really changed. But seems to have stopped ads from propagating. |
|
Is this ready to merge? |
oSumAtrIX
approved these changes
Jun 17, 2025
oSumAtrIX
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
# [5.28.0-dev.5](v5.28.0-dev.4...v5.28.0-dev.5) (2025-06-17) ### Bug Fixes * **Pandora - Disable ads:** Support latest app target ([#5185](#5185)) ([ca83047](ca83047))
github-actions bot
pushed a commit
that referenced
this pull request
Jun 20, 2025
# [5.28.0](v5.27.0...v5.28.0) (2025-06-20) ### Bug Fixes * **Google Photos:** Resolve startup crash if MicroG GmsCore does not already have granted permissions ([a93d74d](a93d74d)) * **Messenger - Remove Meta AI:** Improve patch logic ([#5153](#5153)) ([4ad4887](4ad4887)) * **Pandora - Disable ads:** Support latest app target ([#5185](#5185)) ([ca83047](ca83047)) * **Spotify:** Fix `Hide Create button` and `Sanitize sharing links` for older but supported app targets ([#5159](#5159)) ([e7dd061](e7dd061)) * **Threads - Hide ads:** Constrain patch to the last working app target ([#5189](#5189)) ([3558c44](3558c44)) * **YouTube:** Remove old app targets that are no longer supported by YouTube ([#5192](#5192)) ([c9e54e1](c9e54e1)) ### Features * **Spotify:** Add `Change lyrics provider` patch ([#4937](#4937)) ([8736b6a](8736b6a)) * Use modern style settings dialogs ([#5109](#5109)) ([312b6dc](312b6dc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5182