-
Notifications
You must be signed in to change notification settings - Fork 13
#87 Reference candidate schemas by a descriptive name #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sub-errors is displayed first
Oh, @tfesenko , that is so much better!!! |
@tedepstein , and no changes to the Swagger Schema! |
return description.asText(); | ||
} | ||
// "$ref":"#/definitions/headerParameterSubSchema" | ||
JsonNode ref = swaggerSchemaNode.get("$ref"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to be careful with Refs. I remember seeing in a discussion that JSON Refs can use JSON Pointer as the locator, but they don't have to. I think they may use a different form when it's an external reference. Your algo may still work here, but it's a good idea to check on the JSON Ref specification.
Passed code review. |
@tedepstein , a screenshot with the |
@tfesenko , I would suggest adding a couple of unit tests to prevent future failures:
|
Passed QA. Merging. |
#87 Reference candidate schemas by a descriptive name
@tedepstein, the new error message looks like this:

I replaced the location by a human readable label and sorted the messages so the best candidate (least amount of errors) is displayed first.