Skip to content

Import changes to prepare for gfn #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 29, 2023
Merged

Import changes to prepare for gfn #52

merged 6 commits into from
Nov 29, 2023

Conversation

vict0rsch
Copy link
Collaborator

Copy-pastes (because branches have diverged) from #51

AlexDuvalinho
AlexDuvalinho reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@AlexDuvalinho AlexDuvalinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On peut pas la merge cette branche vu qu'elle contient tous les trucs d'alvaro non-clean...
    Si jamais on merge Alvaro on prendrai juste les ind/depFAENet models, on laisse depSchNet, depD++ tout ca dans sa branche disconnected-gnns au cas ou.

@vict0rsch
Copy link
Collaborator Author

Cette branche va chez Alvaro justement pas dans main

@vict0rsch vict0rsch merged commit de422e7 into disconnected_gnn Nov 29, 2023
@vict0rsch vict0rsch deleted the prepare-disconnected branch November 29, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexDuvalinho AlexDuvalinho AlexDuvalinho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vict0rsch @AlexDuvalinho