Skip to content

No trace method #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2023
Merged

No trace method #158

merged 3 commits into from
Jan 19, 2023

Conversation

JoergSiebahn
Copy link
Contributor

No description provided.

@JoergSiebahn JoergSiebahn requested a review from a team January 18, 2023 17:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2023

Test Results

173 tests  +1   171 ✔️ +1   44s ⏱️ ±0s
  39 suites +1       2 💤 ±0 
  39 files   +1       0 ±0 

Results for commit 2b45fd8. ± Comparison against base commit 807fb57.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
org.sdase.commons.spring.boot.web.security.validation.CustomObjectMapperAdviceTest ‑ shouldPreventStartupIfTracingIsEnabled()
org.sdase.commons.spring.boot.web.security.validation.om.CustomObjectMapperAdviceTest ‑ shouldPreventStartupIfSdaObjectMapperIsNotConfigured()
org.sdase.commons.spring.boot.web.security.validation.trace.SecureMethodsAdviceTest ‑ shouldPreventStartupIfTracingIsEnabled()

♻️ This comment has been updated with latest results.

@JoergSiebahn JoergSiebahn marked this pull request as ready for review January 18, 2023 17:15
@JoergSiebahn JoergSiebahn enabled auto-merge (rebase) January 18, 2023 17:15
@JoergSiebahn JoergSiebahn mentioned this pull request Jan 18, 2023
1 task

@EnableWebSecurity
@ComponentScan
@AutoConfiguration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found this article about auto configuration:
https://www.baeldung.com/spring-boot-custom-auto-configuration#creating-a-custom-auto-configuration

Do we really need to register the class in a resources/META-INF/spring.factories file?

Maybe that would be the missing link 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spring.factories is deprecated for v3 and replaced by ...AutoConfiguration.imports since 2.7

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phew 🤣

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.4% 86.4% Coverage
0.0% 0.0% Duplication

@JoergSiebahn JoergSiebahn merged commit 1307ec8 into master Jan 19, 2023
@JoergSiebahn JoergSiebahn deleted the no-trace-method branch January 19, 2023 07:51
@JoergSiebahn JoergSiebahn mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants