-
Notifications
You must be signed in to change notification settings - Fork 3
Document security hardening and enable security for sda platform #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document security hardening and enable security for sda platform #163
Conversation
3cd4a7d
to
9d18686
Compare
fa7a13b
to
3e59468
Compare
3e59468
to
a5a1f3b
Compare
a5a1f3b
to
d87963f
Compare
attack the operating system after taking over from the container. | ||
|
||
The default configuration is capable to run as no root, listening to ports 8080 and 8081. | ||
Deployment checks must ensure, that the container is not configured with a root user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to give an example K8S deployment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho that will just add boilerplate to this page and move the focus away from the list of addressed risks.
docs/security/index.md
Outdated
|
||
## Risk: Loss of source IP address | ||
|
||
We expect, the services built with sda-spring-boot-commons are deployed behind a proxy, e.g. an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the -> that? Or "We assume that..."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I „expect“ that. If you expose the service directly, you have to disable the filter.
@@ -11,8 +11,7 @@ Features: | |||
- [Jackson Object Mapping](#jackson) | |||
- [Monitoring](#monitoring) | |||
- [Tracing](#tracing) | |||
- [Health Checks](#health-checks) | |||
- [Testing](#testing) | |||
- [Health Checks](#health-checks--actuator) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bullet point list does not include "security". Should we add it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho not. These links are just anchors within the page. I would not mix it with links to different pages. I added the security page to the mkdocs. Whenever we provide github pages or Backstage docs, it will be visible in the main nav. But that's a separate PR.
@EnableSdaRestGuide | ||
@EnableSdaWebSecurity | ||
@EnableSdaDocs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would've preferred EnableSdaOpenApiDocs
or similar but that's not part of the review / changes.
ed92c9c
to
001d08d
Compare
Kudos, SonarCloud Quality Gate passed!
|
Note: Security is already available for auto configured services. Users of
@EnableSdaPlatform
get the security features as well now.