-
Notifications
You must be signed in to change notification settings - Fork 72
[SYNPY-1547] parentWikiId=""
Bug
#1165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BWMac
commented
Feb 12, 2025
BryanFauble
reviewed
Feb 12, 2025
BryanFauble
reviewed
Feb 12, 2025
BryanFauble
reviewed
Feb 12, 2025
BryanFauble
reviewed
Feb 12, 2025
BryanFauble
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good logically, just a few minor points
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A user reported an unhandled error when trying to store a Wiki object in Synapse like so (where syn123 is instead a valid Synapse project ID that the user has access to):
This happened because the API does not treat that value of
parentWikiId
like aNone
value and instead throws an error. To prevent that error from happening, I added logic inWiki.__init__
that converts any falsey value that is provided forparentWikiId
toNone
.Additionally, the user was receiving this error message:
rather than a message passed on from the API which I addressed by updating logic here to check the response text.
Testing:
After these changes were made, the script above was able to be run successfully. I also added a unit test to ensure that
parentWikiId=""
is treated likeparentWikiId=None
and an integration test to ensure that Wiki objects created withparentWikiId=""
are stored successfully in Synapse.