Skip to content

[SYNPY-1579] Introduce the materialized view #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

BryanFauble
Copy link
Member

@BryanFauble BryanFauble commented Apr 11, 2025

Problem:

Solution:

  • Create the MaterializedView class, a tutorial for the changes, and a bunch of different examples

Testing:

  • Manual testing to verify the changes behave as expected
  • A tutorial to showcase the model
  • Integration tests verifying the changes

Links to resources:

  1. Tutorial: https://synapsepythonclient--1190.org.readthedocs.build/en/1190/tutorials/python/materializedview/
  2. Sync API Reference: https://synapsepythonclient--1190.org.readthedocs.build/en/1190/reference/experimental/sync/materializedview/
  3. Async API Reference: https://synapsepythonclient--1190.org.readthedocs.build/en/1190/reference/experimental/async/materializedview/

@BryanFauble BryanFauble requested a review from a team as a code owner April 11, 2025 22:32
@BryanFauble BryanFauble requested review from Copilot and removed request for a team April 11, 2025 22:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

@BryanFauble BryanFauble changed the title [DPE-1579] Introduce the materialized view [SYNPY-1579] Introduce the materialized view Apr 11, 2025
@thomasyu888 thomasyu888 requested a review from a team April 14, 2025 17:13
Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was able to follow-along with the tutorial and run the script that comes with it.

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Thanks for the work and review! I looked at all the tests and they look great.

@BryanFauble BryanFauble merged commit 2deac75 into develop Apr 14, 2025
4 of 5 checks passed
@BryanFauble BryanFauble deleted the dpe-1579-materialized-view branch April 14, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants