Skip to content

IsDeleted returns true if DeletedAt is not zero #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

EtienneM
Copy link
Member

Fix #84

@EtienneM EtienneM requested a review from Soulou April 16, 2019 09:05
@Soulou
Copy link
Member

Soulou commented Apr 16, 2019

is NOT zero (PR name is wrong)

@EtienneM EtienneM changed the title IsDeleted returns true if DeletedAt is zero IsDeleted returns true if DeletedAt is not zero Apr 16, 2019
@EtienneM EtienneM force-pushed the fix/84/is_deleted_is_zero branch from b71fe0c to 9bc6b13 Compare April 16, 2019 09:08
@EtienneM EtienneM requested a review from Soulou April 16, 2019 09:11
@Soulou
Copy link
Member

Soulou commented Apr 16, 2019

LGTM

@Soulou Soulou merged commit d9563d8 into master Apr 16, 2019
@EtienneM EtienneM deleted the fix/84/is_deleted_is_zero branch April 16, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Paranoid] IsDeleted should also check if time.Time is zero
2 participants