loginLocalLabel versus localLoginLabel

[GBirkel]

Summary

Configuration values for loginLocalLabel and localLoginLabel are both present in the codebase. Which is valid?

https://github.com/search?q=repo%3ASciCatProject%2Fscicat-backend-next+loginLocalLabel+localLoginLabel&type=code

Expected Behaviour

The loginLocalLabel name seems to me more consistent with others. Is that the one we should consolidate to?

Details

I don't want to just pick one myself and submit a PR because this could possibly affect production deployments. Does anyone have opinions/thought on which to use, or why there are currently these two?

[bpedersen2]

https://github.com/search?q=org%3ASciCatProject+localLoginLabel++&type=code
shows this is only in test and older template configs

https://github.com/search?q=org%3ASciCatProject+loginLocalLabel&type=code
=> this is used in the frontend

[nitrosx]

@GBirkel localLoginLabel is a legacy setting and should be removed.
loginLocalLabel is the one currently used, which is consistent with the other login settings.

It would be great if you can submit the PR to remove localLoginLabel.
Thanks

[GBirkel]

Sounds good. I'll add it to the to-do list.

[nitrosx]

Thank you so much