Allow ChainRulesCore 1.0 #102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 75.13% 74.76% -0.37%
==========================================
Files 19 19
Lines 543 543
==========================================
- Hits 408 406 -2
- Misses 135 137 +2
Continue to review full report at Codecov.
|
|
This fails Flux tests after upgrading to ChainRules 1.0, so we definitely have fixes needing to go in here. https://buildkite.com/julialang/flux-dot-jl/builds/1496#7bb3aa82-4fcd-4b7f-a3c9-e3de7006c4fa |
|
Actually, Flux tests are pulling in [email protected] instead of 0.11, so the compat entry and a release would be great @jonniedie |
|
Also tests seem to be pulling an old version of Zygote in CI (v0.4.20 vs v0.6.19). Might be that other compat bounds need to be set. |
|
Could we re run ci here? |
|
To be honest, I'm not really sure how to troubleshoot this. Running the tests locally in a fresh temp environment doesn't run into any of these problems. I also can't reproduce the Zygote @v0.4.20 thing, even by forcing all of the versions of the other packages to the versions they show in the CI run. Any ideas? |
|
we may just need to restart the CI. |
|
Oh, well it looks like that did it. There's a segfault on nightly, but it doesn't seem to have to do with ComponentArrays. Is that a Zygote thing? |
|
I've been seeing it in many places but not sure where it's coming from. |
|
Okay cool. Well I'll go ahead and merge this then. Nightly's gonna nightly. |
|
Thanks for doing this @oxinabox. Sorry it took so long for me to get around to merging it. |
|
no problem. |
I haven't actually looked at the code to see if anything else is needed,
lets see what CI says