-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Collect JVM heap dump only enable via env var #2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit b644318)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Refactored heap dump handling to remove reliance on
SELENIUM_SERVER_PID
.Simplified process management by removing explicit PID tracking and
wait
commands.Improved heap dump script to dynamically detect
selenium-server.jar
process.Updated all start scripts to align with the new heap dump handling approach.
Changes walkthrough 📝
11 files
Refactor heap dump script to dynamically detect process
Simplify distributor script and update heap dump handling
Simplify event bus script and update heap dump handling
Simplify hub script and update heap dump handling
Simplify node base script and update heap dump handling
Simplify node docker script and update heap dump handling
Simplify router script and update heap dump handling
Simplify session queue script and update heap dump handling
Simplify sessions script and update heap dump handling
Simplify standalone script and update heap dump handling
Simplify standalone docker script and update heap dump handling