Leverage Arrow functions. Browser history nav button issue #5606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have proposed these changes beacuse: - When trying to leverage this on my spfx extension, using yeoman, I had issues on the code and the solution was to implement arrow functions. Also, it makes the code more understable. - I have noticed that when using the back/forwards browser history buttons, doesnt have any effect, when the conditionally page load is in place ( aka page transition ). For instance, you can go to a library, and start to browser among the folders. You will notice that clicking on back/forward doesnt have any effect on page content load. - I have documented how you can pass the url info change to the event handler
|
|
Also replaced `query`per `search`. url.query property returns nothing nowdays.
holylander
commented
Apr 21, 2020
Updated timestamp on file (`ms.date` front matter property) and fixed code formatting issues.
andrewconnell
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Related issues:
What's in this Pull Request?
I have proposed these changes beacuse: