Stop mutating the test terminal's environment #3496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
server
Graphite App
st0012
approved these changes
May 15, 2025
Co-authored-by: Stan Lo <[email protected]>
vinistock
force-pushed
the
05-15-stop_mutating_the_test_terminal_s_environment
branch
from
2b6ad58 to
3aec1e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're finding that mutating the environment of the terminal is not a great experience - especially regarding changing
BUNDLE_GEMFILEto point to our composed gemfile. If users decide to continue running other tasks in the same terminal, a lot of things can go wrong.Implementation
This PR stops mutating the environment and changes our URI require to be relative, so that we don't need the
BUNDLE_GEMFILEto be set in order to require it.