Use a custom executable to hook to test explorer #3499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
vscode
Graphite App
vinistock
force-pushed
the
05-15-use_a_custom_executable_to_hook_to_test_explorer
branch
from
39b1086 to
bf5d586
Compare
vinistock
force-pushed
the
05-15-use_a_custom_executable_to_hook_to_test_explorer
branch
from
bf5d586 to
209425b
Compare
vinistock
added
the
server
alexcrocha
approved these changes
May 16, 2025
vinistock
deleted the
05-15-use_a_custom_executable_to_hook_to_test_explorer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Setting the
RUBYOPTin the user's terminal turned out to not be a great idea. The value persists and if the terminal is reused for other tasks, it may cause those to crash or result in unexpected behaviour.Instead of mutating the terminal environment, we can provide a simple proxy executable that will run the given command with our reporters hooked into it.
Implementation
Created a new executable that simple runs any given command with the modified
RUBYOPTto hook our reporters. That way, we can run terminal tests connecting to the explorer without polluting the user's terminal.Stopped modifying
RUBYOPT.